-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geointerface conversions #156
Conversation
35c8ee3
to
e3e716d
Compare
e3e716d
to
8e8c788
Compare
This should be good to go.
I made this non breaking to reduce friction, there are now both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one suggestion, but this looks good to me! This will be great to have.
It would be nice if we could avoid the .ptr
added in this PR, but it seems like that is probably better addressed separately.
Yes I was thinking about adding a better internal getx etc method, but it can be separate. |
This PR adds the new
geointerface_geomtype
local methods, updatesconvert
to not usecoordinates
, and adds methods to all functions that will work on any compatible geometries.There are some extra methods needed for some constructors to make
convert
more consistent.Its not really practical to test this without wrapper types, the test objects are too limited:
So also waiting on JuliaGeo/GeoInterface.jl#78
We may as well review this now as its basically ready to go, just needs 78 to work. @jw3126 if you would also like to review this that would be helpful.