Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default context of operations from global context to operand context #143

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

jw3126
Copy link
Member

@jw3126 jw3126 commented Nov 6, 2022

This PR makes it more safe and convenient to work with contexts other than the global one.

Before this PR all operations are by default done in the global context.
For objects that were created using another context, this is (almost?) never what you want.

After this PR all operations are by default done in the context of the operands.
I think this almost always what you want. If the contexts of operands mismatch an error is thrown.

  • This PR does not change any behavior if you always work with the default global context.
  • This PR also does not change any behavior if you always pass contexts explicitly.

src/geos_operations.jl Show resolved Hide resolved
src/geos_types.jl Show resolved Hide resolved
Copy link
Member

@yeesian yeesian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants