Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getGeometry and getGeometries in geos operations #102

Conversation

mathieu17g
Copy link
Contributor

Fixes #101

Added:

  • getGeometry and getGeometries in geos operations
  • added in geos function getGeometry, a test on argument n to check if it is between 1 and the number to sub-geometries, and avoid a Julia crash
  • added a dedicated testset on getGeometry and getGeometries

@visr visr mentioned this pull request Mar 3, 2022
mathieu17g and others added 2 commits May 12, 2022 15:48
…coverage

Deleted old commented code on `getGeometry` and `getGeometries` in geos operations

Fallback to `@eval` form and moved docstrings to geos functions

Upgrade versions in CI:
- Julia LTS version v1.3 to v1.6
- checkout: v2 to v3
- codecov-action: v1 to v2

Julia compat raised to 1.6 in project.toml

Added `context` arg in geos operations `getGeometry` and `getGeometries`
@visr visr force-pushed the getGeometry_and_getGeometries_in_geos_operations branch from ee35ba7 to faa4def Compare May 12, 2022 13:50
@visr visr merged commit 39d9d1c into JuliaGeo:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getGeometry and getGeometries in geos operations
2 participants