Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New (breaking) Traits based release #33
New (breaking) Traits based release #33
Changes from 1 commit
0ce3aaa
7f7fa43
668dc52
f7fc274
d47dd88
5ce639b
47281c4
27dc9fe
b727c07
4637713
45dd59a
2ae9581
b252cd1
33df32f
49a4d11
7af21e4
1ba01f5
e6feb6b
0df59c9
497abd3
40c4bcc
b15d130
c537100
49644d7
9ab7e2c
7ee9ace
1805746
567683b
ddee198
6303188
66b68e4
3305aef
19946d7
fa4a26d
4630f13
2c00af7
69b38a7
7bef237
d1d9589
f98a139
cfadd5e
ccd276a
8468fa9
2cc0e07
a22db09
b5f5675
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extent
needs to be implemented.Could it hold/be a
NamedTuple
? Likeextent(obj) = Extent((X=(xmin, xmax), Y=(ymin, ymax)))
etc for how many dimensions there are, using the:X, :Y, :Z, :M
names from the interface.I find this organisation is easier to use than the
xmin, ymin, xmax, ymax
stylebbox
usually uses.(but somehow I missed that its meant to return a
Rectangle
. I guess that makes sense in a different way.)