add coordtype
#167
add coordtype
#167
Conversation
| coordtype(::Point{<:Any,<:Any,<:AbstractArray{T}}) where T = T | ||
| coordtype(::Point{<:Any,<:Any,<:NTuple{<:Any,T}}) where T = T | ||
| coordtype(::Point{<:Any,<:Any,<:NamedTuple{<:Any,<:NTuple{<:Any,T}}}) where T = T |
There was a problem hiding this comment.
Should we remove the Point from here, so that the dispatch with parent(p) for Point feeds into these?
There was a problem hiding this comment.
I think that will hit the fallback method in fallbacks.jl. It just get the X coord type
There was a problem hiding this comment.
should we also add some @test_inferred? Or is it too early for that?
|
GeoInterface implementations: Bridge packages
Readers
Other implementations
|
|
I'm fine with this, but might be good to give a concrete example of what this improves. Do we also want to give some hints using coordtype for let's say GI.coordinates? That's the most type unstable thing I can think of in here. |
|
Yeah, we could use it for (Answered the rest in the issue thread) |
Closes #128
Currently on a GI.MultiPolygon this takes 4ns. Its not a compile time operation. We could put this in the type parameters of the wrapper geometries at construction so its instant.
A lot of packages will be able to set this absolutely to a single type, e.g. Shapefile.jl, GeoJSON.jl and LibGEOS.jl can return
Float64.