use GDAL_jll for binary dependency #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
changed the title
visr
changed the title
We only bump the minimum julia version. Unsupported julia versions will not upgrade to it. Use a minor release to give room for patch releases on v1.0 for older julia versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After quite some effort over at JuliaPackaging/Yggdrasil#293 we managed to create a GDAL_jll.
This uses the new artifacts system and therefore requires the minimum supported Julia version to be set to 1.3. Since GDAL is a rather complicated build, and the new system works much better, I think it is a good deal. This will make it much easier to add more drivers, see #65 for a rough plan.
For reference, LibGEOS.jl already is on the GEOS_jll since JuliaGeo/LibGEOS.jl#65.
For Proj4.jl there is an open pull request at JuliaGeo/Proj.jl#33, which works, but I still want to find a nice solution for dealing with the optional proj-datumgrid data there. They don't have to make the switch at the same time, although I think there is a possibility of getting some interference if they are used together and are on different builds. An additional advantage of this PR is that these packages will share the same *_jll dependencies, avoiding multiple copies.
I'm opening this as a work in progress PR, since it seems this is working fine on OS X and Windows, but not on Linux just yet. The log indicates
GEOS support not enabled, and several of the additional drivers also did not make it in. Work on this can be tracked in JuliaPackaging/Yggdrasil#418.