Don't test FBM on Zygote #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
st--
reviewed
Jul 20, 2021
Co-authored-by: st-- <[email protected]>
st--
previously approved these changes
Jul 20, 2021
|
Eurgh -- our CI on 1.3 gets a different version of Zygote from 1.6. I'm not entirely sure why though... |
|
@st-- I had to make some changes. If you could re-review, that would be grand. |
st--
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been CI failures. I believe I've diagnosed the problem, and have opened an issue about it: FluxML/Zygote.jl#1036
In the mean time, we need our CI to pass, so I've added some tests which are broken, and will be fixed when the issue in question is fixed (so we'll know about it when it happens).