Run Runic after explicit return rule addition #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
commented
Aug 28, 2024
| @@ -266,6 +266,7 @@ function unittest_testsuite(Backend, backend_str, backend_mod, BackendArrayT; sk | |||
| function f(KernelAbstractions.@context, a) | |||
| I = @index(Global, Linear) | |||
| a[I] = 1 | |||
| return # ?? | |||
There was a problem hiding this comment.
Is this valid? This function isn't defined in a macro, but used just below in a @kernel function...
vchuravy
reviewed
Aug 28, 2024
| @@ -62,13 +62,13 @@ function histogram!(histogram_output, input) | |||
| backend = get_backend(histogram_output) | |||
| # Need static block size | |||
| kernel! = histogram_kernel!(backend, (256,)) | |||
| kernel!(histogram_output, input, ndrange = size(input)) | |||
| return kernel!(histogram_output, input, ndrange = size(input)) | |||
There was a problem hiding this comment.
Suggested change
| return kernel!(histogram_output, input, ndrange = size(input)) | |
| kernel!(histogram_output, input, ndrange = size(input)) | |
| return |
| end | ||
|
|
||
| function move(backend, input) | ||
| # TODO replace with adapt(backend, input) | ||
| out = KernelAbstractions.allocate(backend, eltype(input), size(input)) | ||
| KernelAbstractions.copyto!(backend, out, input) | ||
| return KernelAbstractions.copyto!(backend, out, input) |
There was a problem hiding this comment.
Suggested change
| return KernelAbstractions.copyto!(backend, out, input) | |
| KernelAbstractions.copyto!(backend, out, input) | |
| return |
| @@ -22,7 +22,7 @@ function matmul!(output, a, b) | |||
| end | |||
| backend = KernelAbstractions.get_backend(a) | |||
| kernel! = matmul_kernel!(backend) | |||
| kernel!(output, a, b, ndrange = size(output)) | |||
| return kernel!(output, a, b, ndrange = size(output)) | |||
There was a problem hiding this comment.
Suggested change
| return kernel!(output, a, b, ndrange = size(output)) | |
| kernel!(output, a, b, ndrange = size(output)) | |
| return |
| @@ -12,7 +12,7 @@ function mycopy!(A, B) | |||
| @assert get_backend(B) == backend | |||
|
|
|||
| kernel = copy_kernel!(backend) | |||
| kernel(A, B, ndrange = length(A)) | |||
| return kernel(A, B, ndrange = length(A)) | |||
There was a problem hiding this comment.
Suggested change
| return kernel(A, B, ndrange = length(A)) | |
| kernel(A, B, ndrange = length(A)) | |
| return |
| @@ -12,7 +12,7 @@ function mycopy_static!(A, B) | |||
| @assert get_backend(B) == backend | |||
|
|
|||
| kernel = copy_kernel!(backend, 32, size(A)) # if size(A) varies this will cause recompilation | |||
| kernel(A, B, ndrange = size(A)) | |||
| return kernel(A, B, ndrange = size(A)) | |||
There was a problem hiding this comment.
Suggested change
| return kernel(A, B, ndrange = size(A)) | |
| kernel(A, B, ndrange = size(A)) | |
| return |
| @@ -101,6 +101,7 @@ function transform_gpu!(def, constargs, force_inbounds) | |||
| Expr(:block, let_constargs...), | |||
| body, | |||
| ) | |||
| return def # or nothing? | |||
There was a problem hiding this comment.
Suggested change
| return def # or nothing? | |
| return |
| @@ -135,6 +136,7 @@ function transform_cpu!(def, constargs, force_inbounds) | |||
| Expr(:block, let_constargs...), | |||
| Expr(:block, new_stmts...), | |||
| ) | |||
| return def # or nothing? | |||
There was a problem hiding this comment.
Suggested change
| return def # or nothing? | |
| return |
| @@ -266,6 +266,7 @@ function unittest_testsuite(Backend, backend_str, backend_mod, BackendArrayT; sk | |||
| function f(KernelAbstractions.@context, a) | |||
| I = @index(Global, Linear) | |||
| a[I] = 1 | |||
| return # ?? | |||
| @@ -266,6 +266,7 @@ function unittest_testsuite(Backend, backend_str, backend_mod, BackendArrayT; sk | |||
| function f(KernelAbstractions.@context, a) | |||
| I = @index(Global, Linear) | |||
| a[I] = 1 | |||
| return # ?? | |||
There was a problem hiding this comment.
Suggested change
| return # ?? | |
| return |
| @@ -43,5 +43,5 @@ function unroll_testsuite(backend, ArrayT) | |||
| kernel!(a, Val(5)) | |||
| kernel2! = kernel_unroll2!(backend(), 1, 1) | |||
| kernel2!(a) | |||
| synchronize(backend()) | |||
| return synchronize(backend()) | |||
There was a problem hiding this comment.
Suggested change
| return synchronize(backend()) | |
| synchronize(backend()) | |
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.