Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to removal of CombineMulAdd pass. #645

Merged
merged 2 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ jobs:
strategy:
fail-fast: false
matrix:
version: ['1.10', 'pre', 'nightly']
version: ['1.10', '1.11', 'nightly']
os: [ubuntu-latest, macOS-latest, windows-latest]
arch: [x64]
llvm_args: ['']
include:
# starting with Julia 1.10, we can enable opaque pointers
# from Juila 1.12 on, this is the default.
# from Julia 1.12 on, this is the default.
- version: '1.10'
os: 'ubuntu-latest'
arch: 'x64'
Expand All @@ -37,15 +37,15 @@ jobs:
os: 'windows-latest'
arch: 'x64'
llvm_args: '--opaque-pointers'
- version: 'pre'
- version: '1.11'
os: 'ubuntu-latest'
arch: 'x64'
llvm_args: '--opaque-pointers'
- version: 'pre'
- version: '1.11'
os: 'macOS-latest'
arch: 'x64'
llvm_args: '--opaque-pointers'
- version: 'pre'
- version: '1.11'
os: 'windows-latest'
arch: 'x64'
llvm_args: '--opaque-pointers'
Expand Down
4 changes: 3 additions & 1 deletion src/optim.jl
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,9 @@ end
function buildCleanupPipeline(mpm, @nospecialize(job::CompilerJob), opt_level)
if opt_level >= 2
add!(mpm, NewPMFunctionPassManager()) do fpm
add!(fpm, CombineMulAddPass())
if VERSION < v"1.12.0-DEV.1390"
add!(fpm, CombineMulAddPass())
end
add!(fpm, DivRemPairsPass())
end
end
Expand Down
Loading