Unify isapprox with Base.isapprox #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In JuliaLang/julia#22742 isapprox changed from using atol + rtol*max(abs(x), abs(y))) to using max(atol, rtol*max(abs(x), abs(y))))
|
Just realized that the main issue I was dealing with was actually the definition of Since this only arose in some testing code for me, I'm going to punt on it for now. But can throw up an issue instead of this PR if desired. |
|
Could you post an MWE that shows the issue? In case anybody wants to tackle this. |
|
bors try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JuliaLang/julia#22742
isapproxchanged from usingatol + rtol*max(abs(x), abs(y)))to using
max(atol, rtol*max(abs(x), abs(y))))