Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update due to changes in GNSSSignals #40

Merged
merged 9 commits into from
Nov 23, 2022
Merged

Update due to changes in GNSSSignals #40

merged 9 commits into from
Nov 23, 2022

Conversation

zsoerenm
Copy link
Member

Bump GNSSSignals to v0.16 and remove BOC specialized code.

Copy link
Contributor

@dominformant dominformant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/tracking_state.jl Show resolved Hide resolved
@@ -11,6 +11,7 @@ struct TrackingResults{
}
state::TS
correlator::C
filtered_prompt::ComplexF64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a special reason for putting the filtered prompt signal in the tracking results? In my opinion, this is quite unsafe to evaluate, as the tracking loop might generate more than one prompt (or even no).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's like correlator, but filtered. correlator holds the last valid correlation results (after a complete code length has been integrated). The same applies to filtered prompt. filtered_prompt is needed because in some circumstances the filter can not be reconstructed outside of track. The implementation here allows to update the states of the post correlation filter every time there are new correlation results. Therefore, the state of the post correlation filter might be different at the time that track returns.

@codecov-commenter
Copy link

Codecov Report

Merging #40 (274d85f) into master (0d46f7e) will increase coverage by 4.65%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   79.52%   84.17%   +4.65%     
==========================================
  Files          17       17              
  Lines         503      512       +9     
==========================================
+ Hits          400      431      +31     
+ Misses        103       81      -22     
Impacted Files Coverage Δ
src/Tracking.jl 100.00% <ø> (ø)
src/tracking_results.jl 91.30% <33.33%> (-3.94%) ⬇️
src/correlator.jl 92.30% <100.00%> (ø)
src/downconvert.jl 52.94% <100.00%> (ø)
src/post_corr_filter.jl 100.00% <100.00%> (ø)
src/tracking_loop.jl 94.65% <100.00%> (+6.46%) ⬆️
src/tracking_state.jl 95.83% <100.00%> (+0.27%) ⬆️
src/downconvert_and_correlate.jl 32.60% <0.00%> (+32.60%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zsoerenm zsoerenm merged commit 4264924 into master Nov 23, 2022
@zsoerenm zsoerenm deleted the ss/use-get_codes branch November 23, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants