Fix rounding errors for code generation #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coezmaden
reviewed
Dec 6, 2021
| @@ -25,12 +25,13 @@ function gen_code_replica!( | |||
| most_late_sample_shift = correlator_sample_shifts[1] | |||
| total_samples = num_samples + most_early_sample_shift - most_late_sample_shift | |||
There was a problem hiding this comment.
Commenting only on variable naming: wouldn't it be better to name the variables latest_sample_shiftand earliest_sample_shift?
There was a problem hiding this comment.
Actually, this would lead to shorter variable names, but is probably out of scope here, what do you think @zsoerenm?
There was a problem hiding this comment.
Yes, I support this change. Would you mind to create a pull request @ozmaden ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/JuliaGNSS/GNSSSignals.jl/pulls