Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use code generation from GNSSSignals.jl #29

Merged
merged 11 commits into from
Sep 9, 2021
Merged

Conversation

dominformant
Copy link
Contributor

The tracking of BOC-Signals requires to load the code with non-integer phases to enable the subcarrier generation.
Using FixedPointNumbers.jl gives comparable speed as the current implementation while providing the fractional phase in the code access.

@zsoerenm
Copy link
Member

zsoerenm commented Sep 8, 2021

I have added CI for all new pull request right here on Github. There are still some errors (see below).

@dominformant dominformant changed the title Switch phase calculation to FixedPointNumbers [WIP] Switch phase calculation to FixedPointNumbers Sep 8, 2021
@dominformant
Copy link
Contributor Author

Actually, the code generation can simplified here, as soon as JuliaGNSS/GNSSSignals.jl#21 is merged.

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2021

Codecov Report

Merging #29 (95d2e7a) into master (379c19f) will decrease coverage by 1.71%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
- Coverage   90.97%   89.26%   -1.72%     
==========================================
  Files          16       16              
  Lines         432      419      -13     
==========================================
- Hits          393      374      -19     
- Misses         39       45       +6     
Impacted Files Coverage Δ
src/code_replica.jl 100.00% <100.00%> (ø)
src/downconvert.jl 52.94% <0.00%> (-8.83%) ⬇️
src/Tracking.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379c19f...95d2e7a. Read the comment docs.

@dominformant dominformant changed the title [WIP] Switch phase calculation to FixedPointNumbers Use code generation from GNSSSignals.jl Sep 9, 2021
@zsoerenm
Copy link
Member

zsoerenm commented Sep 9, 2021

The test is failing because the minimal Julia version that is required by the new GNSSSignals.jl is v1.6
So I guess Project.toml and .github/workflows/ci.yml need to reflect this change

@dominformant
Copy link
Contributor Author

Code generation is now implemented by GNSSSignals.jl to enhance code reuse. Minimum Julia version is increased to 1.6 as required by GNSSSignals.jl.

@dominformant dominformant merged commit 73a7f9b into master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants