Improve directory setup #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files to that directory. Also deleted files that are not needed anymore.
…Network from AbstractNeuralNetworks) and simplified symbolic parameter generation to a single function 'symbolize\!'.
… partially from docstring tests.
Fixed typos.
|
This is set to draft until all tests from the docstrings are moved to appropriate places. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 72.30% 80.39% +8.08%
==========================================
Files 16 11 -5
Lines 325 255 -70
==========================================
- Hits 235 205 -30
+ Misses 90 50 -40 ☔ View full report in Codecov by Sentry. |
benedict-96
force-pushed
the
improve-directory-setup
branch
2 times, most recently
from
206a914 to
bbd5d70
Compare
ps -> nn.params. Vector can't be used on Tuple of Vectors (apparently). [1., 2.] -> Vector(1:input_dim) (so that we can deal with flexible input dimensions.
benedict-96
force-pushed
the
improve-directory-setup
branch
3 times, most recently
from
5ebf5f1 to
1b873e9
Compare
Flipped order of functions. Added _get_contents method for Tuple as argument. Added another method to deal with Zygote idiosyncracies. Fixed method for _get_params.
benedict-96
force-pushed
the
improve-directory-setup
branch
from
1b873e9 to
a260ae5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved readability of directory setup and moved tests from docstrings to separate files.
I also added another constructor for
SymbolicNeuralNetwork, which should be used as the default:That way we do not have to implement custom
symbolicparameterfunctions for each new layer.