Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformer integrator #131

Merged
merged 11 commits into from
Apr 15, 2024
Merged

Transformer integrator #131

merged 11 commits into from
Apr 15, 2024

Conversation

benedict-96
Copy link
Collaborator

Introduced a new type TransformerIntegrator that makes the transformer behave similarly to a classical multi-step method. For now this is done by extending iterate, but will have to be interfaced with GeometricIntegratorsBase eventually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo: "the defualt is"

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 73.75000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 64.46%. Comparing base (88f903c) to head (9b622e9).

Files Patch % Lines
src/architectures/transformer_integrator.jl 45.16% 17 Missing ⚠️
src/arrays/symplectic.jl 80.95% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   63.31%   64.46%   +1.14%     
==========================================
  Files         114      117       +3     
  Lines        3260     3309      +49     
==========================================
+ Hits         2064     2133      +69     
+ Misses       1196     1176      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benedict-96
Copy link
Collaborator Author

Fixed the typo and adjusted the interface in the docs which meant the Documenter workflow was crashing before.

@michakraus michakraus merged commit dda979e into main Apr 15, 2024
13 of 16 checks passed
@michakraus michakraus deleted the transformer_integrator branch April 15, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants