Remove unnecessary dependencies #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing (iv): I needed to exclude some of the lines in backends/lux.jl; I'm not sure if we need this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 67.18% 67.56% +0.37%
==========================================
Files 97 97
Lines 2514 2500 -14
==========================================
Hits 1689 1689
+ Misses 825 811 -14 ☔ View full report in Codecov by Sentry. |
|
The documentation workflow is also not going through for now, but this is because the interface in |
|
Just resolved the merge conflict that appeared as a result of #120 ... the CI tests (except nightly probably, but including the Documenter) should go through now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed (i) CUDA (ii) ForwardDiff (iii) GPUArrays (iv) Lux. Regarding (iv) from
Project.toml. The CUDA dependency meant that the tests for nightly didn't go through; the hope was that they are going through now (but it seems Zygote is posing a similar problem). I've also commented out some of the functions inbackends/lux.jlto be able to remove (iv). I'm not sure if we should keep this backend and, if we want to keep it, if we have to import Lux to do so.