Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed NLsolve and Optimisers dependency. #106

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

benedict-96
Copy link
Collaborator

Removed two of the dependencies we had in the issue.

@benedict-96 benedict-96 requested a review from michakraus January 8, 2024 08:10
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d42e956) 68.27% compared to head (711f6fa) 68.27%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   68.27%   68.27%           
=======================================
  Files          96       96           
  Lines        2440     2440           
=======================================
  Hits         1666     1666           
  Misses        774      774           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michakraus michakraus merged commit 512850f into main Jan 8, 2024
12 of 15 checks passed
@michakraus michakraus deleted the remove_dependencies branch January 8, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants