Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constructor tests for custom arrays #99

Merged
merged 107 commits into from
Dec 20, 2023
Merged

Constructor tests for custom arrays #99

merged 107 commits into from
Dec 20, 2023

Conversation

benedict-96
Copy link
Collaborator

Added tests for the constructors in src/arrays. Also fixed docs for rgrad in stiefel_manifold.jl and data_loader/tensor_assign.jl.

@benedict-96
Remove old array tests.
ba96b35
@benedict-96
Removed the block matrices. This is now done by the LinearSympNetLayers.
0fb9156
@benedict-96
Hope this fixed the TODO list.
dd4e8a5
@benedict-96
We are not using those arrays anymore.
35c0d48
@benedict-96
Factored out sampling of arrays.
1f1e30d
@benedict-96
Got rid of some some symplectic arrays and included the supertype for…
51c7c76 
… horizontal components as an extra file.
@benedict-96
Updated docs.
3876be5
@benedict-96
New supertype for the horizontal components.
48300b2
@benedict-96
Added new routine for multiplying symmetric matrix from the right ont…
0dfbc63 
…o a matrix.
@benedict-96
Test addition of various custom arrays.
21bb931
@benedict-96
Removed tests for various symplectic arrays that are no longer part o…
969a6cb 
…f GML.
@benedict-96
Added routine for Base.one. This is copied from SkewSymMatrix.
e0b81cf
@benedict-96
Slightly improved readability.
16b28ba
@benedict-96
Added addition tests for the remaining custom arrays.
df07bfb
@benedict-96
Added tests for addition, scalar multiplication and matrix multiplica…
e81ff2e 
…tion for custom arrays.
@benedict-96
Changed order of how files are included. Symmetric now depends on Ske…
a94c57c 
…wSymmetric.
@benedict-96
Fixed typo.
c6a350e
@benedict-96
Fixed docs and put type dependency for .
3e01f05
@benedict-96
Fixed docs for rgrad.
3a1fa6a
@benedict-96
Added additional constructor for the case when the type is the first …
3b8b5a4 
…input argument.
@benedict-96
Removed the symplectic arrays.
b05c66c
@benedict-96
Added tests for the various constructors for custom arrays.
71f791b
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (0be53b2) 64.10% compared to head (569df79) 68.30%.
Report is 80 commits behind head on main.

Files Patch % Lines
src/arrays/symplectic.jl 0.00% 15 Missing ⚠️
src/arrays/symmetric.jl 11.11% 8 Missing ⚠️
src/optimizers/optimizer.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   64.10%   68.30%   +4.20%     
==========================================
  Files         100       96       -4     
  Lines        2591     2439     -152     
==========================================
+ Hits         1661     1666       +5     
+ Misses        930      773     -157

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

benedict-96 and others added 28 commits December 20, 2023 09:03
@benedict-96
Resolved conflict (removed triangular matrices).
65ee5c0
@benedict-96
Slightly improved readability.
0f958d6
@benedict-96
Resolved conflict.
250c701
@benedict-96
Resolved conflict (accepted both changes).
b320aaf
@benedict-96
Added tests for addition, scalar multiplication and matrix multiplica…
5ae3067 
…tion for custom arrays.
@michakraus
Merge pull request #100 from JuliaGNI/simplify_transformer_tests
9dbdb58 
Simplify transformer tests
@benedict-96
Resolved merge conflict.
d4bbb6c
@benedict-96
Fixed (apparent) conflict.
f25e3fa
@benedict-96
Fixed typo.
e0cc2d2
@benedict-96
Resolved merge conflicts.
b7bf98b
@benedict-96
Fixed comments from previous merge conflict.
1e659d7
@benedict-96
Fixed docs and put type dependency for .
5710860
@benedict-96
Fixed docs for rgrad.
ce78b93
@benedict-96
Added additional constructor for the case when the type is the first …
f6dda17 
…input argument.
@benedict-96
Resolved conflict (forgot to resolve another one before).
99e83e6
@benedict-96
Added tests for the various constructors for custom arrays.
02b5b31
@benedict-96
Removed the symplectic arrays.
36bb2a9
@benedict-96
Merge branch 'constructor_tests_for_custom_arrays' of https://github.…
7eb3c36 
…com/JuliaGNI/GeometricMachineLearning.jl into constructor_tests_for_custom_arrays
@michakraus
Merge pull request #98 from JuliaGNI/multiplication_and_addition_test…
eb94a21 
…s_for_custom_arrays

Multiplication and addition tests for custom arrays
@benedict-96
Fixed docs and put type dependency for .
e6b2d34
@benedict-96
Fixed docs for rgrad.
f28680f
@benedict-96
Added additional constructor for the case when the type is the first …
3456fc5 
…input argument.
@benedict-96
Resolved conflict (forgot to resolve another one before).
f202264
@benedict-96
Added tests for the various constructors for custom arrays.
c4cdd51
@benedict-96
Removed the symplectic arrays.
f388a4c
@benedict-96
Resolved merge conflict.
882fa04
@benedict-96
Removed the symplectic arrays.
2aa6919
@benedict-96
Merge branch 'constructor_tests_for_custom_arrays' of https://github.…
569df79 
…com/JuliaGNI/GeometricMachineLearning.jl into constructor_tests_for_custom_arrays
@michakraus michakraus merged commit 45cece4 into main Dec 20, 2023
12 of 15 checks passed
@michakraus michakraus deleted the constructor_tests_for_custom_arrays branch December 20, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michakraus michakraus Awaiting requested review from michakraus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benedict-96 @michakraus