Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify transformer tests #100

Merged
merged 58 commits into from
Dec 20, 2023
Merged

Simplify transformer tests #100

merged 58 commits into from
Dec 20, 2023

Conversation

benedict-96
Copy link
Collaborator

Cleaned up the transformer related tests and gave them names. Before they were just called "Transformer Networks #1", Transformer Networks #2" etc.

@benedict-96
Remove old array tests.
ba96b35
@benedict-96
Removed the block matrices. This is now done by the LinearSympNetLayers.
0fb9156
@benedict-96
Hope this fixed the TODO list.
dd4e8a5
@benedict-96
We are not using those arrays anymore.
35c0d48
@benedict-96
Factored out sampling of arrays.
1f1e30d
@benedict-96
Got rid of some some symplectic arrays and included the supertype for…
51c7c76 
… horizontal components as an extra file.
@benedict-96
Updated docs.
3876be5
@benedict-96
New supertype for the horizontal components.
48300b2
@benedict-96
Removed tests for various symplectic arrays that are no longer part o…
969a6cb 
…f GML.
@benedict-96
Fixed docs for optimize_for_one_epoch
5d58358
@benedict-96
Added descriptions for some functions in the docs.
b43fb39
@benedict-96
Added eltype to AbstractCache.
d032f3e
@benedict-96
Removed comments that seem to have become unnecessary.
81ac240
@benedict-96
Removed symplectic part (again).
9002452
@benedict-96
Refactored all the transformer tests and gave each of them a name.
4c82474
@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (0be53b2) 64.10% compared to head (dd343b9) 67.47%.
Report is 45 commits behind head on main.

Files Patch % Lines
src/arrays/symplectic.jl 0.00% 15 Missing ⚠️
src/optimizers/optimizer.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   64.10%   67.47%   +3.36%     
==========================================
  Files         100       96       -4     
  Lines        2591     2429     -162     
==========================================
- Hits         1661     1639      -22     
+ Misses        930      790     -140

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

benedict-96 and others added 13 commits December 19, 2023 13:07
@benedict-96
Renamed file to something more descriptive.
35b3db6
@benedict-96
Renamed file to something meaningful and made the test more readable.
66f3279
@michakraus
Merge pull request #97 from JuliaGNI/put_sampling_of_arrays_into_extr…
e8ba5c1 
…a_test_file

Put sampling of arrays into extra test file
@benedict-96
Added descriptions and a wrapper for using the custom loss function w…
257aeee 
…ith NeuralNetwork.
@benedict-96
Added descriptions and a wrapper for using the custom loss function w…
9ca60ed 
…ith NeuralNetwork.
@benedict-96
Added documentation.
fced8d8
@benedict-96
Added constructor for optimizer if input arguments are flipped.
d95268d
@benedict-96
Added a comment saying that the constructor can be called with DataLo…
2abed87 
…ader as input.
@benedict-96
Added default for number of epochs.
0f62b8f
@benedict-96
Combined matrix and tensor routines into one. Added another loss for …
3ab42f2 
…autoencoder qp data.
@benedict-96
Commented out a section that is probably not needed.
5d22855
@benedict-96
Test data loader for qp data.
86485ad
@benedict-96
Renamed and added tests.
cac1f18
benedict-96 and others added 28 commits December 19, 2023 18:24
@benedict-96
Renamed file to something meaningful and made the test more readable.
f4ddd3f
@benedict-96
Added descriptions and a wrapper for using the custom loss function w…
92ac2fe 
…ith NeuralNetwork.
@benedict-96
Added descriptions and a wrapper for using the custom loss function w…
cb19f5b 
…ith NeuralNetwork.
@benedict-96
Added documentation.
cb7725f
@benedict-96
Added constructor for optimizer if input arguments are flipped.
90bbaa7
@benedict-96
Added a comment saying that the constructor can be called with DataLo…
137d640 
…ader as input.
@benedict-96
Added default for number of epochs.
b57d148
@benedict-96
Combined matrix and tensor routines into one. Added another loss for …
3100b0b 
…autoencoder qp data.
@benedict-96
Commented out a section that is probably not needed.
718174f
@benedict-96
Test data loader for qp data.
370ee05
@benedict-96
Renamed and added tests.
14d6ae2
@benedict-96
Adjusted symplectic matrix.
9edec7b
@benedict-96
dim was missing for specifying default.
2acdd24
@benedict-96
dl has no field data.
f8b8fff
@benedict-96
Fixed typos.
8c4c73b
@benedict-96
Merge branch 'increase_data_loader_test_coverage' of https://github.c…
fc92faa 
…om/JuliaGNI/GeometricMachineLearning.jl into increase_data_loader_test_coverage
@benedict-96
Removed method that appeared twice for some reason.
d072594
@benedict-96
Forgot to commit before.
d071839
CompatHelper: bump compat for GPUArrays to 10, (keep existing compat)
2bb3f29
@michakraus
Merge pull request #102 from JuliaGNI/compathelper/new_version/2023-1…
8696833 
…2-20-00-35-42-820-02318887484

CompatHelper: bump compat for GPUArrays to 10, (keep existing compat)
@michakraus
Merge pull request #101 from JuliaGNI/increase_data_loader_test_coverage
9b56781 
Increase data loader test coverage
@benedict-96
Fixed docs for optimize_for_one_epoch
d160bcf
@benedict-96
Added descriptions for some functions in the docs.
b35e5e2
@benedict-96
Added eltype to AbstractCache.
8fe4832
@benedict-96
Removed comments that seem to have become unnecessary.
ebc5f71
@benedict-96
Resolved merge conflict with array_tests.jl (i.e. added vectorization…
3c967e8 
… test).
@benedict-96
Added sampling test for custom arrays (resolved conflict).
da77a96
@benedict-96
Resolved merge conflicts (for some reason appeared again).
dd343b9
@michakraus michakraus merged commit 9dbdb58 into main Dec 20, 2023
12 of 15 checks passed
@michakraus michakraus deleted the simplify_transformer_tests branch December 20, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michakraus michakraus Awaiting requested review from michakraus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benedict-96 @michakraus