Fix Partition() w/ size greater than the length of the input
#529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #529 +/- ##
==========================================
+ Coverage 95.33% 95.43% +0.09%
==========================================
Files 32 32
Lines 2230 2232 +2
==========================================
+ Hits 2126 2130 +4
+ Misses 104 102 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MasonProtter
approved these changes
Sep 19, 2022
|
Hey @LebedevRI I’ve finally got the test suite working. Could you rebase on Master? That should get all tests passing and then I can merge. |
`complete()` only worked correctly if at least a single full partition has been produced already, otherwise the `buf` would be smaller than the `xform(rf).size`, and we get buffer overflow, etc. I've added sufficient test coverage for the issue, that now passes. I have stumbled into this while trying to write a reduction tree, not sure if this is something that might be interesting here? Fixes JuliaFolds#528
LebedevRI
force-pushed
the
fix-Partition-for-less-than-one-output
branch
from
6245a2a
to
2bf2e55
Compare
|
I've rebased, but did nothing other than that. I don't know if this still works, or needs further changes. |
|
Great, thanks @LebedevRI! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
complete()only worked correctly if at least a single full partitionhas been produced already, otherwise the
bufwould be smallerthan the
xform(rf).size, and we get buffer overflow, etc.I've added sufficient test coverage for the issue, that now passes.
I have stumbled into this while trying to write a reduction tree,
not sure if this is something that might be interesting here?
Fixes #528