Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The first release v0.1.0 #21

Merged
merged 11 commits into from
Oct 7, 2019
Merged

The first release v0.1.0 #21

merged 11 commits into from
Oct 7, 2019

Conversation

TeroFrondelius
Copy link
Member

No description provided.

@TeroFrondelius
Copy link
Member Author

Depends JuliaRegistries/General#4117

@coveralls
Copy link

coveralls commented Oct 7, 2019

Pull Request Test Coverage Report for Build 103

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 88.319%

Totals Coverage Status
Change from base Build 89: -0.7%
Covered Lines: 620
Relevant Lines: 702

💛 - Coveralls

@@ -0,0 +1,3 @@
[deps]
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
Literate = "98b081ad-f1c9-55d3-8b20-4c87d4299306"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I started to feel I am an idiot already.

@ahojukka5
Copy link
Member

It's not documented that well, but docs should have its own Project.toml, defining dependencies for building the documentation, e.g. (https://github.com/JuliaDocs/Documenter.jl/blob/master/docs/Project.toml). So when you do julia --project docs/ you actually activate a new virtual environment. I think this should fix the documentation building.

@TeroFrondelius
Copy link
Member Author

I doubt that because the example will be run and it will need all dependencies.

- stage: "Documentation"
os: linux
script:
- julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate(); Pkg.build()'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's this line saying that you get the dependencies related to this particular package. If you need something else, e.g. Documenter.jl which was in REQUIRE earlier, that needs to specifically require using docs/Project.toml. So basically we don't want that our package depends on Documenter.jl, but the documentation can depend on that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or in other words, if you run julia --activate=docs/ and try to run the example in there, it should fail because the packages are not installed into that virtual environment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's why I felt like an idiot because I couldn't figure out why it's failing.

@TeroFrondelius TeroFrondelius self-assigned this Oct 7, 2019
@TeroFrondelius TeroFrondelius merged commit f58b59b into master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants