Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeCov misses @resumable functions #46

Open
siddharthlal25 opened this issue Jun 29, 2020 · 2 comments
Open

CodeCov misses @resumable functions #46

siddharthlal25 opened this issue Jun 29, 2020 · 2 comments
Milestone
1.0

Comments

@siddharthlal25
Copy link

CodeCov misses @resumable functions even if they have proper tests written.
Related PR: JuliaAstro/CCDReduction.jl#27

PS: I don't know whether I should have opened an issue here or in source repositories of CodeCov about this.
@giordano giordano mentioned this issue Jul 12, 2022
Merged
@Krastanov Krastanov mentioned this issue Aug 7, 2023
Merged
@Krastanov Krastanov added this to the 1.0 milestone Aug 8, 2023
@Krastanov Krastanov mentioned this issue Aug 8, 2023
Merged
Krastanov added a commit that referenced this issue Aug 8, 2023
@Krastanov
Misc improvements to the @resumable macro (#71)
3ec3b15 
- more descriptive names generated symbols
- enable docstrings for `@resumable` functions
- do not delete line number nodes in `@resumable` functions

Fixes #39

Fixes #45

Initial steps needed to address #46

* better names for generated symbols

* make docstrings work with @Resumable

* do not throw away line number information

* tests for line number and docstring preservation

* readme cleanup and version bump

* relax JET tests
@Krastanov
Copy link
Member

might be discussed in more depth here JuliaLang/julia#50834

@Krastanov
Copy link
Member

it seems @resumable clobbers the Method.file property of the newly generated methods. That is probably part of the reason for lack for code coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@Krastanov @siddharthlal25