Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify all DIscrete DS #23

Merged
merged 23 commits into from
Feb 7, 2018
Merged

unify all DIscrete DS #23

merged 23 commits into from
Feb 7, 2018

Conversation

Datseris
Copy link
Member

@Datseris Datseris commented Feb 4, 2018

Closes #22, closes #21, closes #17

@Datseris
Copy link
Member Author

Datseris commented Feb 4, 2018

Please see the file new_discrete.jl and give feedback!

@Datseris
Copy link
Member Author

Datseris commented Feb 4, 2018

@tkf this goes very well with your idea to define a global eom(u, ds) function and similar.

I made a mistake and was computing Jacobian AFTER evolving the state
Make it so that TangentEvolver is part of DDS. Make it so that TangentEvolver does NOT have fields WS is pt.2.
I will only check if documentation makes sense before merging
@Datseris
Copy link
Member Author

Datseris commented Feb 7, 2018

@tkf I am merging this now. Can you be kind to checkout master branch and simply read the docs and fundamental types and see if it is nice and usable for other packages?

High level API: DiscreteDynamicalSystem, evolve and evolve! and trajectory.

Low level API: DiscreteProblem, jacobian, TangentEvolver, ParallelEvolver and their accompanying evolve! methods.

For ChaosTools this is amazing, it simplifies the code, and allows to compute k lyapunovs instead of all, as well as have a step for the QR, (to be done every N steps instead of every 1).

As you suggested ChaosTools will also be reworked to use only evolve, and not directly the fields of basic types.

Merging this will close #17 and I will then open a new issue for it, with a clear plan of implementation.

@Datseris Datseris merged commit 1600c00 into master Feb 7, 2018
@Datseris Datseris mentioned this pull request Feb 7, 2018
14 tasks
@Datseris Datseris deleted the new_discrete branch February 7, 2018 18:04
@tkf
Copy link

tkf commented Feb 8, 2018

@Datseris From a quick look, my comment on #21 (comment) still applies. See also the new comment #21 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants