-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unify all DIscrete DS #23
Conversation
Please see the file |
@tkf this goes very well with your idea to define a global |
to match ODEProblem
even more similarities between continuous and discrete
and also minor tweaks to make everything work like a CLOICK
even more similarity with DiffEq
TODO: Tangent Evolver tests do not pass.
for the case of automated Jacobian!
I made a mistake and was computing Jacobian AFTER evolving the state
woooooow!!!
Make it so that TangentEvolver is part of DDS. Make it so that TangentEvolver does NOT have fields WS is pt.2.
I will only check if documentation makes sense before merging
@tkf I am merging this now. Can you be kind to checkout master branch and simply read the docs and fundamental types and see if it is nice and usable for other packages? High level API: Low level API: For ChaosTools this is amazing, it simplifies the code, and allows to compute As you suggested ChaosTools will also be reworked to use only Merging this will close #17 and I will then open a new issue for it, with a clear plan of implementation. |
@Datseris From a quick look, my comment on #21 (comment) still applies. See also the new comment #21 (comment) |
Closes #22, closes #21, closes #17