Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoming Hypermassive internal change on e.o.m. API #18

Closed
Datseris opened this issue Jan 20, 2018 · 2 comments · Fixed by #19 or JuliaDynamics/ChaosTools.jl#19
Closed

Incoming Hypermassive internal change on e.o.m. API #18

Datseris opened this issue Jan 20, 2018 · 2 comments · Fixed by #19 or JuliaDynamics/ChaosTools.jl#19

Comments

@Datseris
Copy link
Member

The methods and equations of motion of our package will change greatly, following the discussion of SciML/DifferentialEquations.jl#235

In short, the API for all equations of motion will become something like f(du, u, t, p) or f(du, u, p, t) (for out of place methods remove du).

This will also remove all kind of Functor creation of systems since the parameters p are always passed implicitly to the equations of motion. The same syntax will be used for the Jacobian. Using ForwardDiff with this syntax will be very easy nontheless.

The systems now will have a field that also has the parameters. The ODEProblem for continuous systems will have this field, and for discrete they will each have a dedicated field params or something like that.

This will break everything by the way.

@Datseris
Copy link
Member Author

This is under-way on #19.

If it was not clear, these same changes will also happen on Discrete systems!!!!

Datseris added a commit that referenced this issue Jan 26, 2018
@Datseris
Copy link
Member Author

Re-opening until changes also pass in CHaosTools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant