Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around a hang #15

Merged
merged 1 commit into from
May 18, 2023
Merged

Work around a hang #15

merged 1 commit into from
May 18, 2023

Conversation

zickgraf
Copy link

as suggested by @KristofferC in JuliaDocs/Documenter.jl#2121 (comment).

I have verified that this fixes JuliaDocs/Documenter.jl#2121. The yield could also be moved to line 109 (or anywhere in between), but I thought right in front of the place where the hang actually occurs (i.e. the call to f()) would be most fitting.

@mortenpi
Copy link
Member

LGTM, it definitely seems to take care of the hang. Could you also please:

  1. Add a note to CHANGELOG.md about this (under v0.2.3; with an issue reference to here, and to the Documenter issue).
  2. Bump the version number in Project.toml

@zickgraf
Copy link
Author

LGTM, it definitely seems to take care of the hang. Could you also please:

1. Add a note to `CHANGELOG.md` about this (under `v0.2.3`; with an issue reference to here, and to the Documenter issue).

2. Bump the version number in `Project.toml`

Done. I have also added a test while at it.

@mortenpi
Copy link
Member

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doctests never finish if too many "method definition overwritten" warnings appear
2 participants