Make sure that the generated private key is in PEM format #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the default key format generated by
ssh-keygen
has been changed away from PEM (in OpenSSH 8 it looks like; private key files now start withBEGIN OPENSSH PRIVATE KEY
, rather thanBEGIN RSA PRIVATE KEY
). However, this will be a problem on CI where the OpenSSH is old enough that it doesn't support the new format at all.So, to make sure that the keys are always compatible with all systems, let's force DocumenterTools to generate them in PEM, which should be lowest common denominator.
X-ref: https://serverfault.com/questions/939909/ssh-keygen-does-not-create-rsa-private-key