Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the generated private key is in PEM format #48

Merged
merged 4 commits into from
May 7, 2022
Merged

Conversation

mortenpi
Copy link
Member

It looks like the default key format generated by ssh-keygen has been changed away from PEM (in OpenSSH 8 it looks like; private key files now start with BEGIN OPENSSH PRIVATE KEY, rather than BEGIN RSA PRIVATE KEY). However, this will be a problem on CI where the OpenSSH is old enough that it doesn't support the new format at all.

So, to make sure that the keys are always compatible with all systems, let's force DocumenterTools to generate them in PEM, which should be lowest common denominator.

X-ref: https://serverfault.com/questions/939909/ssh-keygen-does-not-create-rsa-private-key

@mortenpi mortenpi added the bug Something isn't working label Feb 20, 2021
@mortenpi mortenpi added this to the 0.1.10 milestone Feb 20, 2021
@mortenpi mortenpi closed this Apr 18, 2021
@mortenpi mortenpi reopened this Apr 18, 2021
@mortenpi mortenpi removed this from the 0.1.10 milestone Apr 18, 2021
@DilumAluthge
Copy link

DilumAluthge commented Apr 22, 2021

@mortenpi It would be great to get this merged.

@mortenpi
Copy link
Member Author

I was almost going to merge this, but then I realized that older ssh-keygen versions might not support the -m argument. So that should be checked first.

@fredrikekre
Copy link
Member

Can use OpenSSH_jll

@mortenpi mortenpi merged commit b8b76e5 into master May 7, 2022
@mortenpi mortenpi deleted the mp/pem branch May 7, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants