Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back color printing #647

Merged
merged 2 commits into from
Feb 24, 2018
Merged

Bring back color printing #647

merged 2 commits into from
Feb 24, 2018

Conversation

fredrikekre
Copy link
Member

also remove an old takebuf_str method.

@fredrikekre
Copy link
Member Author

Unrelated nightly windows failure, requires admin to merge.

@mortenpi
Copy link
Member

Definite 👍 to removing takebuf_str. But what's the actual behavior difference with the colors? As far as I can tell, julia --color=yes docs/make.jl has color and julia docs/make.jl doesn't, both with this PR and current Documenter master, across Julia versions.

@mortenpi mortenpi added this to the 0.14.0 milestone Feb 23, 2018
@mortenpi
Copy link
Member

Ah OK, the difference is on Travis. The nightly builds still have less color than the 0.6 ones though, even with this PR, but that makes sense since this only touches the doctest printout. But why is Travis colorless with the nightly in the first place, even though Pkg.test() gets called with --color=yes?

@fredrikekre
Copy link
Member Author

fredrikekre commented Feb 23, 2018

See JuliaLang/julia#25067, color printing is now governed by get(io, :color, false) rather than Base.have_color and in the case for this PR we print to an IOBuffer without color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants