-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some deprecations #624
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It would be nice with a new release with this and 611aa82 which should silence most of the warnings.
Will do.
797d8c7
to
4d97a75
Compare
Tests pass now, but there was a newer nightly on macOS, which also included some recent |
Thanks for this! I suspect these deprecations are slowing down the doc build in julia CI quite a bit, so would be good to get this released as soon as possible. |
Looks like DocStringExtensions need to be fixed as well?
on Travis |
Yes, I am waiting for JuliaLang/Compat.jl#457 for that |
Ah, of course. Sorry. |
Can we just take the most direct route possible to getting rid of the deprecations, even if that means an ugly hack here? All the deprecation warnings are causing Base CI to time out. |
Seconded. This is now top priority, as it is slowing down Base development quite a bit. In many cases CI times out because of it. |
The nightly test should pass now. Once it does, I'll merge and tag. |
Building the docs on CI results in a huge amount of depwarn again, fixed most of them.
Needs JuliaLang/Compat.jl#452 to pass on julia 0.6
It would be nice with a new release with this and 611aa82 which should silence most of the warnings.