Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate methods for ^ to use power_by_squaring or pow! #165

Merged
merged 7 commits into from
Apr 20, 2018

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Apr 17, 2018

No description provided.

@lbenet
Copy link
Member Author

lbenet commented Apr 17, 2018

This implements a suggestion of @dpsanders (off-line discussion)

@lbenet
Copy link
Member Author

lbenet commented Apr 17, 2018

This makes that (interval(-1,1) + Taylor1(5)^4 yields the expected result.

@coveralls
Copy link

coveralls commented Apr 17, 2018

Coverage Status

Coverage decreased (-0.2%) to 98.085% when pulling 8141256 on lb/power_by_squaring into 81b4649 on master.

@dpsanders
Copy link
Contributor

Maybe add some tests with intervals? That would require adding IntervalArithmetic.jl to test/REQUIRE.

@lbenet
Copy link
Member Author

lbenet commented Apr 17, 2018

Good point; I'll implement some tests for intervals.

@lbenet
Copy link
Member Author

lbenet commented Apr 17, 2018

Due to the use of power_by_squaring, some intervals arising from (t-a)^n (a is an Interval) are actually wider than the explicit formula, which evaluates a^k with appropriate k. This is simply the dependency problem.

@lbenet
Copy link
Member Author

lbenet commented Apr 17, 2018

I think this is ready for review.

@lbenet
Copy link
Member Author

lbenet commented Apr 18, 2018

Tests are passing and 4d5ac34 provided narrower intervals.

@lbenet lbenet requested a review from dpsanders April 18, 2018 18:09
@lbenet lbenet merged commit 3035cde into master Apr 20, 2018
@lbenet lbenet deleted the lb/power_by_squaring branch May 17, 2018 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants