Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add displayBigO to set/unset printing the bigO notation #139

Merged
merged 2 commits into from
Nov 27, 2017
Merged

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Nov 22, 2017

This commit also addresses some deprecation warnings for Julia 0.7.

@lbenet
Copy link
Member Author

lbenet commented Nov 22, 2017

Addresses #134.

@dpsanders Can you suggest a better name than displayBigO? Once this is set, I'll add it to the documentation.

@lbenet
Copy link
Member Author

lbenet commented Nov 22, 2017

Once #137 is merged, it will require a rebase...

@coveralls
Copy link

coveralls commented Nov 22, 2017

Coverage Status

Coverage increased (+0.009%) to 95.985% when pulling 657e833 on lb/bigO into 8a8d3fb on master.

This commit also addresses some deprecation warnings for Julia 0.7.
@lbenet
Copy link
Member Author

lbenet commented Nov 24, 2017

Rebased to current master...

@coveralls
Copy link

coveralls commented Nov 24, 2017

Coverage Status

Coverage increased (+0.009%) to 96.171% when pulling 2018955 on lb/bigO into 8c385c7 on master.

@lbenet
Copy link
Member Author

lbenet commented Nov 24, 2017

@dpsanders Suggestion for a better name, instead of displayBigO?

I just added the docs, and think this is ready to be reviewed and perhaps merged.

@lbenet
Copy link
Member Author

lbenet commented Nov 25, 2017

If it's ok with you @dpsanders, I'll merge this PR and tag a new version.

Due to the changes introduced in #135 I guess the proper thing to do is to tag it as 0.7.0. Some development in TaylorIntegration is awaiting for such new tag...

@lbenet lbenet merged commit 5d9794f into master Nov 27, 2017
@lbenet
Copy link
Member Author

lbenet commented Nov 27, 2017

Merged!

@dpsanders
Copy link
Contributor

Sorry I didn't get round to looking at it. It's very nice, thanks!

@lbenet lbenet deleted the lb/bigO branch December 5, 2017 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants