Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutating functions #129

Merged
merged 18 commits into from
Oct 27, 2017
Merged

Mutating functions #129

merged 18 commits into from
Oct 27, 2017

Conversation

lbenet
Copy link
Member

@lbenet lbenet commented Oct 17, 2017

This PR provides some low-level functionality to be used with metaprogramming; see PerezHz/TaylorIntegration.jl#31.

Luis Benet and others added 16 commits October 10, 2017 14:40
Use explicit recursion for acos in acos! ...
7b7f0f5 
...instead of using asin!
Add internalmutfunct.jl
838c2e1
Add unary add! subst! and other methods, and ammend dictionaries
9a01be5
Small corrections
7eb6e65
Rename internalmutfunct.jl to dictmutfunct.jl and export constant_term
99deece
Add identity! and another method of constant_term
a6a15ea
Add zero! and one! methods
dab08e4
Add mul! and div! involving numeric coefficients
9ae4454
Include in _internalmutfunc_call TayloSeries before the function
0f8d545
Revise the docstrings
58d5b16
Add specific cases depending on the power to pow!
0473b2d
@PerezHz
Add missing methods for add! and subst! (#117)
2be408d 
* Add missing in-place methods for unary +,-

* Add tests for new add!, subst! methods
Add abs!
6e65d7b
Add abs2(a) as a^2, and the corresponding abs2!
fa81ce8
Correct abs! so it works for Taylor1{TaylorN{T}}
5d956f2
Import abs2
6b7f938
@lbenet
Copy link
Member Author

lbenet commented Oct 17, 2017

While tests are passing, I would like to add more to keep the coverage we currently have.

@lbenet lbenet closed this Oct 17, 2017
@lbenet lbenet deleted the mutating_functions branch October 17, 2017 14:52
@lbenet lbenet restored the mutating_functions branch October 17, 2017 14:52
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.3%) to 93.775% when pulling 6b7f938 on mutating_functions into d2eedd7 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.3%) to 93.775% when pulling 6b7f938 on mutating_functions into d2eedd7 on master.

@lbenet
Copy link
Member Author

lbenet commented Oct 17, 2017

Reopening... wrong button.

@lbenet lbenet reopened this Oct 17, 2017
@lbenet lbenet requested a review from dpsanders October 17, 2017 15:52
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 96.22% when pulling 6b7f938 on mutating_functions into d2eedd7 on master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 17, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.9%) to 96.22% when pulling 6b7f938 on mutating_functions into d2eedd7 on master.

@coveralls
Copy link

coveralls commented Oct 17, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.9%) to 96.22% when pulling d359144 on mutating_functions into d2eedd7 on master.

@coveralls
Copy link

coveralls commented Oct 19, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 96.296% when pulling 3fe32bb on mutating_functions into d2eedd7 on master.

@lbenet lbenet merged commit cde8874 into master Oct 27, 2017
@lbenet
Copy link
Member Author

lbenet commented Oct 27, 2017

Merging.

@PerezHz PerezHz mentioned this pull request Oct 28, 2017
Merged
@lbenet lbenet deleted the mutating_functions branch March 25, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpsanders dpsanders Awaiting requested review from dpsanders

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbenet @coveralls @PerezHz