Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement to_vec for PermutedDimsArray #108

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Implement to_vec for PermutedDimsArray #108

merged 3 commits into from
Sep 23, 2020

Conversation

willtebbutt
Copy link
Member

@willtebbutt willtebbutt commented Sep 7, 2020 •
edited
Loading

Does what it says in the title.

@mcabbott would appreciate knowing if this solves your problem and your review if you've got the time.

@willtebbutt willtebbutt mentioned this pull request Sep 7, 2020
Merged
@willtebbutt
Copy link
Member Author

This is necessary to get JuliaDiff/ChainRules.jl#261 merged

@mcabbott
Copy link
Member

mcabbott commented Sep 9, 2020

Thanks, will have a look but maybe not today!

@willtebbutt
Copy link
Member Author

@wesselb @nickrobinson251 any chance that one of you could take a look at this so I can get it in?

@willtebbutt willtebbutt merged commit 0ea31d4 into master Sep 23, 2020
@willtebbutt willtebbutt deleted the wct/permuteddimsarray_tovec branch September 23, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrobinson251 nickrobinson251 nickrobinson251 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@willtebbutt @mcabbott @nickrobinson251