Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculus.symbolic_derivative_1arg_list masking some definitions #30

Closed
goretkin opened this issue Dec 1, 2015 · 3 comments
Closed

Calculus.symbolic_derivative_1arg_list masking some definitions #30

goretkin opened this issue Dec 1, 2015 · 3 comments

Comments

@goretkin
Copy link

goretkin commented Dec 1, 2015

I might be confused, but

julia> @which abs2(Dual(1.0,1.0))
abs2(z::DualNumbers.Dual{T<:Real}) at /Users/goretkin/.julia/v0.4/DualNumbers/src/dual.jl:186

https://github.com/JuliaDiff/DualNumbers.jl/blob/v0.1.5/src/dual.jl#L186
which is masking a previous definition on
https://github.com/JuliaDiff/DualNumbers.jl/blob/v0.1.5/src/dual.jl#L122

@MikaelSlevinsky
Copy link
Contributor

This should be taken care of by #29.

@ScottPJones
Copy link
Contributor

This still seems to be a problem, at least on v0.5 master, even with #29 merged.
I get this warning:

julia> using DualNumbers
INFO: Precompiling module DualNumbers...
WARNING: Method definition abs2(DualNumbers.Dual4) in module DualNumbers at /Users/scott/.julia/v0.5/DualNumbers/src/dual_n.jl:78 overwritten at /Users/scott/.julia/v0.5/DualNumbers/src/dual_n.jl:154.

@MikaelSlevinsky
Copy link
Contributor

This line was added in dual.jl to skip abs2. Perhaps the same could be done in dual_n.jl

@mlubin mlubin closed this as completed in c8d9601 Mar 20, 2016
mlubin added a commit that referenced this issue Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants