-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: preproject
and project
implementation
#383
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
==========================================
+ Coverage 89.12% 89.73% +0.60%
==========================================
Files 14 15 +1
Lines 561 604 +43
==========================================
+ Hits 500 542 +42
- Misses 61 62 +1
Continue to review full report at Codecov.
|
closed in favour of #385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #380 and #382. See usage in JuliaDiff/ChainRules.jl#457. Uses @mcabbott's
preproject(x)
idea (somewhere I can't find) instead of a closure. This is cool because it allows theproject(T, dx)
to be extended depending on both theSome observations (comments welcome):
projector
implementation (returning a closure) #382 it allows us to not close over primal value (x
)projector
implementation (returning a closure) #382, where the returned closure can not be extended, theproject
function can be extended by someone developing aQuaternions
package. They would simply defineproject(::Type{Real}, dx::Quaternion) = ...
project
implementation #380 where there are 3-arg functions. On the other hand callingproject
now also needs aninfo
kwarg which stores the information about the primalx
, such as size or element type.preproject
returns a nested NamedTuple of required info. Similarly theproject
can just peel off the necessaryinfo
and pass it on to the innerproject
call.There are still some things I need to address from @mcabbott's comments on #382, but just putting it out here for discussion.
IMO this is the best way forward of the three PRs. Thoughts?