Implement Base.:(==) for thunks
#367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 9, 2021 16:24
mzgubic
commented
Jun 9, 2021
| @@ -1,6 +1,12 @@ | |||
| @testset "Thunk" begin | |||
| @test @thunk(3) isa Thunk | |||
|
|
|||
| @testset "==" begin | |||
| @test @thunk(3.2) == InplaceableThunk(@thunk(3.2), x -> x + 3.2) | |||
There was a problem hiding this comment.
Do we want to have this? Or should we separate between Thunks and InplaceableThnks?
There was a problem hiding this comment.
(@thunk(3.2)) == 3.2
Inplacable(@thunk(3.2), _->error("this shouldn;t be hit")) == 3.2
Thus by transitivity thye must be equal to each other
oxinabox
reviewed
Jun 9, 2021
| @@ -13,6 +13,10 @@ end | |||
| return element, (val, new_state) | |||
| end | |||
|
|
|||
| Base.:(==)(a::AbstractThunk, b::AbstractThunk) = unthunk(a) == unthunk(b) | |||
There was a problem hiding this comment.
There are some special case we might be able to optimize the positive cases like a===b to avoid unthunking.
idk if worth it though
oxinabox
approved these changes
Jun 9, 2021
|
Looks like it adds some new ambiguities and makes Aqua CI unhappy now: Ambiguity #1
==(a::ChainRulesCore.AbstractThunk, b) in ChainRulesCore at /Users/jc/.julia/packages/ChainRulesCore/EgLlm/src/differentials/thunks.jl:26
==(::Any, ::Missing) in Base at missing.jl:76
Ambiguity #2
==(a, b::ChainRulesCore.AbstractThunk) in ChainRulesCore at /Users/jc/.julia/packages/ChainRulesCore/EgLlm/src/differentials/thunks.jl:27
==(::Missing, ::Any) in Base at missing.jl:75
Ambiguity #3
==(a::ChainRulesCore.AbstractThunk, b) in ChainRulesCore at /Users/jc/.julia/packages/ChainRulesCore/EgLlm/src/differentials/thunks.jl:26
==(w, v::WeakRef) in Base at gcutils.jl:5
Ambiguity #4
==(a, b::ChainRulesCore.AbstractThunk) in ChainRulesCore at /Users/jc/.julia/packages/ChainRulesCore/EgLlm/src/differentials/thunks.jl:27
==(w::WeakRef, v) in Base at gcutils.jl:4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for defining
to_vecfor@thunks, which is needed for testing all kinds of differentials