-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Vararg in @non_differentiable macro #254
Conversation
On top of your branch. When I do something like: julia> @non_differentiable vcat(::Any, ::Vararg{AbstractArray{Int}}) it works just fine. But doing: julia> @non_differentiable vcat(::Any, ::AbstractArray{Int}...)
syntax: "::AbstractArray{Int}" is not a valid function argument name
Stacktrace:
[1] top-level scope at /Users/gaurav/.julia/packages/IJulia/a1SNk/src/kernel.jl:53 Is the second an incorrect Julia syntax? |
Thanks for taking a look so quickly and catching this bug. What you showed is correct Julia syntax and should have been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
Some comments that you should adress before merging, but I don't think this will need further review
Closes #212 .