RFC: add GPU testing #646
RFC: add GPU testing #646
Conversation
mcabbott
force-pushed
the
gputest
branch
4 times, most recently
from
603dd88
to
468b7fd
Compare
| Expr(:block, ex, Expr(:macrocall, Symbol("@test_broken"), __source__, ex2)) |> esc | ||
| else | ||
| Expr(:block, ex, Expr(:macrocall, Symbol("@test"), __source__, ex2)) |> esc | ||
| # NB this @test should report a line number in your tests, not here. |
There was a problem hiding this comment.
we really need to document how to make macros do that.
Here is one of the ways
https://github.com/JuliaLogging/LoggingExtras.jl/blob/be221f3147856a7fb2c2dcbd8ea202610a65725d/src/verbosity.jl#L1-L11
|
@mcabbott is there a reason why a release wasn't registered after merging this PR or was it an oversight? |
|
No strong reason! It doesn't change any functionality, only testing, maybe that's why. |
The PR bumped the minor version though. Should we then make a release with that minor version or save it for the next release? |
|
Since this is blocking 2 releases, I'm going to assume the version bump was intentional and release a new version. |
This wants to start adding GPU tests...
JLArrayfrom New package: JLArrays v0.1.0 JuliaRegistries/General#64443 so that this can run on github actions / random laptops.@gpuin front oftest_rrule(sum, rand(3))expands to first run the test as before, then check the GPU result. No attempt is made to run all the tests this way.Xref #617 -- note that there is now GPUArraysCore.jl, so CR can use
@allowscalar, and dispatch onAbstractGPUArray, without loading anything heavy.Xref #645 -- that particular rule needs to be re-written, marked broken here.