Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update support for timing internals #608

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Update support for timing internals #608

merged 3 commits into from
Apr 22, 2022

Conversation

IanButterworth
Copy link
Contributor

@IanButterworth IanButterworth commented Apr 20, 2022 •
edited by mcabbott
Loading

These internals were consolidated in JuliaLang/julia#45015

Closes #609

@mcabbott
Copy link
Member

If you allow JuliaInterpreter 0.9 then I think tests will run:

ChainRules.jl/Project.toml

Line 21 in f13e0a4

JuliaInterpreter = "0.8" # latest is "0.9.1"

@IanButterworth
Copy link
Contributor Author

Thanks. Seems like CompatHelper needs fixing on this repo?

@devmotion
Copy link
Member

I don't think CompatHelper deals with compat entries for test dependencies in Project.toml (not test/Project.toml)?

@mcabbott
Copy link
Member

Failure on x64 is not new, same as https://github.com/JuliaDiff/ChainRules.jl/runs/5705588458?check_suite_focus=true . Failure on x86 is weird.

@JuliaDiff JuliaDiff locked and limited conversation to collaborators Apr 21, 2022
@JuliaDiff JuliaDiff unlocked this conversation Apr 21, 2022
@devmotion
Copy link
Member

In case anyone is wondering about (un)locking the conversation: I pressed the wrong buttons in the Android app. Sorry for the unrelated noise.

@devmotion devmotion mentioned this pull request Apr 21, 2022
Closed
mcabbott
mcabbott approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nicer if tests pass, but I think we should do this.

Can you increase the version number too?

@mcabbott mcabbott merged commit c294a9a into JuliaDiff:main Apr 22, 2022
@IanButterworth IanButterworth deleted the ib/cumulative_time_func_fix branch April 22, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcabbott mcabbott mcabbott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR: LoadError: Failed to precompile ChainRules, on Julia master
3 participants
@IanButterworth @mcabbott @devmotion