Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rrule for complex-valued determinants #601

Merged
merged 6 commits into from
Mar 20, 2022
Merged

Fix rrule for complex-valued determinants #601

merged 6 commits into from
Mar 20, 2022

Conversation

goerz
Copy link
Contributor

@goerz goerz commented Mar 20, 2022

Closes #600

sethaxen
sethaxen reviewed Mar 20, 2022
View reviewed changes
Copy link
Member

@sethaxen sethaxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! A couple very minor suggestions. And, can you also increment the patch version?

src/rulesets/LinearAlgebra/dense.jl Outdated Show resolved Hide resolved
test/rulesets/LinearAlgebra/dense.jl Outdated Show resolved Hide resolved
@goerz
Copy link
Contributor Author

goerz commented Mar 20, 2022

And, can you also increment the patch version?

Done

@goerz goerz force-pushed the 600-complex-det-rrule branch from 5752740 to d3ecaa9 Compare March 20, 2022 21:38
@goerz
Copy link
Contributor Author

goerz commented Mar 20, 2022

Ok, I think this should be good to go

@sethaxen sethaxen merged commit f13e0a4 into JuliaDiff:main Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethaxen sethaxen sethaxen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rrule for complex-valued det gives wrong result
2 participants
@goerz @sethaxen