Code

Improvements to rules for norm#337

Code

Merged

oxinabox merged 22 commits intoJuliaDiff:masterJuliaDiff/ChainRules.jl:masterfrom mcabbott:normmcabbott/ChainRules.jl:normCopy head branch name to clipboardMay 10, 2021

+180-71

Commits

Commits on May 7, 2021

• widen type of norm pullback, add inplace + tests

  

  Michael Abbott

  authored and

  mcabbott

  committed
  19578d6

  Copy full SHA for 19578d6

• tidy

  

  Michael Abbott

  authored and

  mcabbott

  committed
  9993979

  Copy full SHA for 9993979

• allow, and test, integer x

  

  Michael Abbott

  authored and

  mcabbott

  committed
  6b6487d

  Copy full SHA for 6b6487d

• don't let broadcast allocate ∂x because it's weird

  

  Michael Abbott

  authored and

  mcabbott

  committed
  b03b83d

  Copy full SHA for b03b83d

• one more

  

  Michael Abbott

  authored and

  mcabbott

  committed
  b666c37

  Copy full SHA for b666c37

• Apply suggestions from code review

  Show description for 972b6dd
  

  mcabbott

  and

  simeonschaub

  committed
  972b6dd

  Copy full SHA for 972b6dd

• + tests

  

  Michael Abbott

  authored and

  mcabbott

  committed
  c12b829

  Copy full SHA for c12b829

• a type-stability fix via parent & re-wrap

  

  Michael Abbott

  authored and

  mcabbott

  committed
  e4d60f2

  Copy full SHA for e4d60f2

• comments from review

  mcabbott

  committed
  96eafd6

  Copy full SHA for 96eafd6

• restrict all arrays to eltype Number

  mcabbott

  committed
  07eb77b

  Copy full SHA for 07eb77b

• skip UpperHessenberg

  mcabbott

  committed
  d3833fc

  Copy full SHA for d3833fc

• version

  mcabbott

  committed
  79ecf73

  Copy full SHA for 79ecf73

• move branches into InplaceableThunk

  mcabbott

  committed
  f1b5ba4

  Copy full SHA for f1b5ba4

• give up on inplacethunk

  mcabbott

  committed
  3f893e4

  Copy full SHA for 3f893e4

• try to find out where we are

  mcabbott

  committed
  46bf4c5

  Copy full SHA for 46bf4c5

• don't count the thunks

  mcabbott

  committed
  71d4ac9

  Copy full SHA for 71d4ac9

• rm nested unthunking

  mcabbott

  committed
  e400bd5

  Copy full SHA for e400bd5

• make tests pass

  mcabbott

  committed
  81f85b7

  Copy full SHA for 81f85b7

• comments

  mcabbott

  committed
  43a2756

  Copy full SHA for 43a2756

• update notation

  mcabbott

  committed
  0331eda

  Copy full SHA for 0331eda

• tidy

  mcabbott

  committed
  69a92dc

  Copy full SHA for 69a92dc

• integer comment

  Show description for 87e4313
  

  mcabbott

  and

  oxinabox

  committed
  87e4313

  Copy full SHA for 87e4313