bump the minimum supported Julia version to 1.10 (LTS) #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
avi/bump-Julia-1.10
branch
from
1d36c46
to
cfad4e7
Compare
Maintaining this package that closely depends on Julia internals across multiple Julia versions is very cumbersome. Now that the LTS has been updated to 1.10, let's drop compatibility with earlier versions and simplify the code.
aviatesk
force-pushed
the
avi/bump-Julia-1.10
branch
from
cfad4e7
to
6a2b89d
Compare
| else | ||
| return Some{Any}(Core.get_binding_type(getargs(args, frame)...)) | ||
| end | ||
| return Some{Any}(Core.get_binding_type(getargs(args, frame)...)) |
There was a problem hiding this comment.
I thought splatting here was bad for inference, which is why n == 2 was special cased before?
There was a problem hiding this comment.
Now the compiler has the special casings for these builtin functions and it doesn't register any tfuncs for them. Maybe we can recover tfuncs that are simplified version of the special cases.
KristofferC
reviewed
Nov 14, 2024
KristofferC
reviewed
Nov 14, 2024
Co-authored-by: Kristoffer Carlsson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining this package that closely depends on Julia internals across multiple Julia versions is very cumbersome. Now that the LTS has been updated to 1.10, let's drop compatibility with earlier versions and simplify the code.