Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thread-safety note for NetCDF4 #451

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

danlooo
Copy link
Member

@danlooo danlooo commented Oct 16, 2024

see #450

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.38%. Comparing base (775ce9c) to head (c9f55a2).
Report is 38 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   68.40%   69.38%   +0.98%     
==========================================
  Files          12       12              
  Lines        1807     1813       +6     
==========================================
+ Hits         1236     1258      +22     
+ Misses        571      555      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11365186998

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 69.464%

Files with Coverage Reduction New Missed Lines %
src/DAT/DAT.jl 1 76.05%
Totals Coverage Status
Change from base Build 10982138529: 0.0%
Covered Lines: 1258
Relevant Lines: 1811

💛 - Coveralls

@felixcremer
Copy link
Member

Could we make this documentation a bit more explicit and show on an example how to use these locks for threadsafe opening a NetCDF?

@lazarusA lazarusA merged commit 44a9d70 into JuliaDataCubes:master Oct 16, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants