Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rebuild #441

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix rebuild #441

merged 1 commit into from
Sep 19, 2024

Conversation

briochemc
Copy link
Contributor

@briochemc briochemc commented Sep 19, 2024

rebuild(oldarray; data=newdata)

was throwing with

ERROR: UndefVarError: `dims` not defined

but

rebuild(oldarray; data=newdata, dims=dims(oldarray))

seemed to work so I think this quick fix might help? (Not sure!)

Side question: Are there enough tests for rebuild?

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.40%. Comparing base (59d23fc) to head (775ce9c).
Report is 45 commits behind head on master.

Files with missing lines Patch % Lines
src/Cubes/Cubes.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
+ Coverage   68.30%   68.40%   +0.09%     
==========================================
  Files          12       12              
  Lines        1773     1807      +34     
==========================================
+ Hits         1211     1236      +25     
- Misses        562      571       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Sep 19, 2024

Pull Request Test Coverage Report for Build 10935264448

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.476%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Cubes/Cubes.jl 0 1 0.0%
Totals Coverage Status
Change from base Build 10829126157: 0.0%
Covered Lines: 1236
Relevant Lines: 1805

💛 - Coveralls

@lazarusA
Copy link
Collaborator

thanks!

@lazarusA lazarusA merged commit b4b08dd into JuliaDataCubes:master Sep 19, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants