Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UnROOT to INTEGRATIONS.md replacing UpROOT #351

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

Moelf
Copy link
Contributor

@Moelf Moelf commented Nov 8, 2023

uproot is not recommended anymore with UnROOT is much more mature now

uproot is not recommended anymore with UnROOT is much more mature now
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6bafed9) 93.68% compared to head (44f33de) 94.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   93.68%   94.39%   +0.70%     
==========================================
  Files           7        7              
  Lines         602      624      +22     
==========================================
+ Hits          564      589      +25     
+ Misses         38       35       -3     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkamins
Copy link
Member

bkamins commented Nov 8, 2023

I cannot see this recommendation in the readme.md of either of these packages.

@Moelf
Copy link
Contributor Author

Moelf commented Nov 8, 2023

the uproot repo has:

There also exists a pure-Julia ROOT file reading library UnROOT.jl that is built for speed and memory efficiency.

@bkamins
Copy link
Member

bkamins commented Nov 8, 2023

I saw this, but it does not mean that this is preferred. In other words: are you sure that UpRoot.jl maintainers are OK with removing a reference to their package here that we already have?

@Moelf
Copy link
Contributor Author

Moelf commented Nov 8, 2023

yes, basically we (JuliaHEP) don't think people should be using Uproot via Python unless for missing issues such as writing out .root files, but the Table interface is most useful for reading, and I don't want it to be confusing for new users

@bkamins bkamins merged commit 3dd8df2 into JuliaData:master Nov 8, 2023
12 checks passed
@Moelf Moelf deleted the patch-1 branch November 8, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants