Add rounding and transposition methods #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to be provided by DataArrays.
These used to be provided by DataArrays, and are needed to transpose an
Array{Union{T, Null}} since these functions are called recursively.
nalimilan
commented
Oct 5, 2017
| for f in (:(Base.ceil), :(Base.floor), :(Base.round), :(Base.trunc)) | ||
| @eval begin | ||
| ($f)(::Null, digits::Integer=0, base::Integer=0) = null | ||
| ($f)(::Type{>:Null}, ::Null) = null |
There was a problem hiding this comment.
This one is a bit special: I've considered round(Int, null) should throw a NullException, but round(Union{Int, Null}, null) should return null. That's safer than returning null whatever the requested type. When NullException supports error messages, we should use it to explain what to do.
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
+ Coverage 91.86% 92.13% +0.27%
==========================================
Files 1 1
Lines 86 89 +3
==========================================
+ Hits 79 82 +3
Misses 7 7
Continue to review full report at Codecov.
|
This was referenced Oct 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used to be provided by DataArrays, needed for JuliaStats/DataArrays.jl#288.