add in-place macros @transform! and @select! #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdeffebach
requested changes
Dec 16, 2020
FuZhiyu
commented
Dec 17, 2020
pdeffebach
reviewed
Dec 18, 2020
|
Thanks! Just a bit more then I'll have Milan or Bogumil take a look. |
Co-authored-by: pdeffebach <[email protected]>
pdeffebach
approved these changes
Dec 18, 2020
|
Thanks! This looks good to me! cc @nalimilan to take a look at it before merging. |
nalimilan
reviewed
Dec 19, 2020
nalimilan
reviewed
Dec 28, 2020
correct typos and formatting issues. Co-authored-by: Milan Bouchet-Valat <[email protected]>
Co-authored-by: Milan Bouchet-Valat <[email protected]>
nalimilan
approved these changes
Dec 29, 2020
|
Wonderful!! Thank you! Really appreciate the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple PR to add in-place macros in response to #215.
Suggestions welcomed.