RFC: generate get/setindex() #816
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- generate getindex()/setindex!() for all possible combination of input parameters, including ::Colon - throw KeyError/DomainMismatch instead of generic exceptions
|
@kleinschmidt sorry for the noise, for some reason git has put you in during the rebase |
|
Are there missing getindex/setindex! methods currently? I'm not aware of any complaints or open issues about it, so I'm not sure this is worht the churn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR replaces "hand-written"
getindex()/setindex!()methods with the generator for all possible combination of input parameters, including::Colon.With the recent introduction of explicit
::Colonin Julia v0.4, the number of methodsgetindex()/setindex!()methods would grow considerably, so the patch spares from the necessity of all these redundant declarations.The generator is 100 lines less that the current hand-written code, maybe just a little bit more complicateв. It passes the tests on 0.3 and it would also pass the tests on 0.4 if the DataArrays.jl would be patched with JuliaStats/DataArrays.jl#152