Override getproperty, setproperty! and propertynames for AbstractDataFrame and DataFrameRow #1406
Conversation
…Frame and DataFrameRow Provides a nice shorthand syntax for simple getindex and setindex! uses, with autocompletion, and makes DataFrameRow more like NamedTuple. This requires replacing all direct field accesses with calls to accessor functions. Do not mention this feature in the manual yet since it is not available on a released Julia version. Most uses of df[:col] will better be changed to df.col when Julia 0.7 is released.
| Base.getproperty(df::AbstractDataFrame, col_ind::Symbol) = getindex(df, col_ind) | ||
| Base.setproperty!(df::AbstractDataFrame, col_ind::Symbol, x) = setindex!(df, x, col_ind) | ||
| # Private fields are never exposed since they can conflict with column names | ||
| Base.propertynames(df::AbstractDataFrame, private::Bool=false) = names(df) |
There was a problem hiding this comment.
I'm not sure what's the best solution here. This situation is going to arise for other types where field names are dynamic. We could also throw an error when private == true.
|
Fixes #1336? |
There was a problem hiding this comment.
@nalimilan Very nice - thank you. I have reviewed the code and it looks OK.
I have one question though (unfortunately I am unable to test it locally currently).
How does the . notation work with non-standard column names. What I mean by this is a name like Symbol("Column 1"). It is accessible via the method call I guess - right? But can it be accessed via . somehow or it is not possible? I guess those things should be eventually mentioned in the docs.
|
Thanks, I had forgotten about this!
I'm not sure, but indeed I think you'd need to call |
Provides a nice shorthand syntax for simple getindex and setindex! uses, with autocompletion,
and makes
DataFrameRowmore likeNamedTuple.This requires replacing all direct field accesses with calls to accessor functions.
Do not mention this feature in the manual yet since it is not available on a released Julia
version. Most uses of
df[:col]will better be changed todf.colwhen Julia 0.7 is released.(CI failure on 0.7 is fixed with DataStreams master.)
Fixes #1336.