Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in CSV.read docstring #114

Closed
nickeubank opened this issue Nov 25, 2017 · 3 comments
Closed

Error in CSV.read docstring #114

nickeubank opened this issue Nov 25, 2017 · 3 comments

Comments

@nickeubank
Copy link

nickeubank commented Nov 25, 2017

I think Line 247 of src/Source.jl of should have a period for element-wise operation. I think it should read:

string.(::WeakRefString)

not

string(::WeakRefString)

I don't have a cloned / forked copy of CSV -- would someone in the project mind fixing? I know it's poor form to note these things without a PR, but seems small enough I'd appreciate if someone on the team would be willing to patch.

[Edit: clarification of problem]: Otherwise, at least when there are missing values, the output is something like:

string(df[:date])

"Union{Missings.Missing, WeakRefString{UInt8}}[\"September 13, 2017\", \"September 14, 2017\", \"September 15, 2017\", \"September 16, 2017\", \"September 17, 2017\", \"September 18, 2017\", \"September 19, 2017\", \"September 20, 2017\", \"September 21, 2017\", \"September 22, 2017\", \"September 23, 2017\", \"September 24, 2017\", \"September 25, 2017\", \"September 26, 2017\", \"September 27, 2017\", \"September 28, 2017\", \"September 29, 2017\", \"September 30, 2017\", \"October 1, 2017\", \"October 2, 2017\", \"October 3, 2017\", \"...

Instead of:


string.(df[:date])

String[59]
"September 13, 2017"
"September 14, 2017"
"September 15, 2017"
"September 16, 2017"
"September 17, 2017"
"September 18, 2017"
"September 19, 2017"
"September 20, 2017"
"September 21, 2017"
"September 22, 2017"
...
"November 1, 2017"
"November 2, 2017"
"November 3, 2017"
"November 4, 2017"
"November 5, 2017"
"November 6, 2017"
"November 7, 2017"
"November 8, 2017"
"November 9, 2017"
"November 10, 2017"

Thanks!

@nalimilan
Copy link
Member

Thanks for the report. Even if you don't have clone the repository, for simple cases like this you can make a PR by editing the file on GitHub.

nickeubank added a commit to nickeubank/CSV.jl that referenced this issue Nov 26, 2017
@nickeubank
Copy link
Author

Right! Thanks @nalimilan -- submitted a PR

@quinnj
Copy link
Member

quinnj commented Jan 6, 2018

Addressed in #143

@quinnj quinnj closed this as completed Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants