Simplify 3-arg conv, remove unnecessary inbounds
#610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #610 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 19 19
Lines 3248 3248
=======================================
Hits 3182 3182
Misses 66 66 ☔ View full report in Codecov by Sentry. |
CartesianIndices(A)
slightly faster on v1.10, about the same on v1.6
wheeheee
force-pushed
the
conv_tweaks
branch
from
f4c218d to
99f9247
Compare
Co-authored-by: Martin Holters <[email protected]>
|
Yes, most of the blocks inbounds was applied to did not have functions with checkbounds / propagate_inbounds. I didn't see much performance difference when benchmarking. |
Co-authored-by: Martin Holters <[email protected]>
martinholters
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.